Page MenuHomePhabricator
Differential D4298

Separate CSeederNode class declaration from definition
ClosedPublic
Actions

Authored by nakihito on Oct 25 2019, 22:35.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING46ff7d5583c1: Separate CSeederNode class declaration from definition
rABC46ff7d5583c1: Separate CSeederNode class declaration from definition
Summary

Separating the declaration from the definition of this class to allow
unit testing in the future without having to include bitcoin.cpp.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BreakUpBitcoincpp
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7878
Build 13771: Bitcoin ABC Buildbot (legacy)
Build 13770: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 25 2019, 22:35
Owners added a reviewer: Restricted Owners Package.Oct 25 2019, 22:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2019, 22:35
nakihito planned changes to this revision.Oct 25 2019, 22:35
teamcity added a comment.Oct 25 2019, 22:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito updated this revision to Diff 13717.Oct 25 2019, 22:37

Removed extra new line.

nakihito planned changes to this revision.Oct 25 2019, 22:37
teamcity added a comment.Oct 25 2019, 22:37

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 25 2019, 22:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7878: Diff 13716.Oct 25 2019, 22:45
teamcity added a comment.Oct 25 2019, 22:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7879: Diff 13717.Oct 25 2019, 22:52
nakihito requested review of this revision.Oct 27 2019, 00:10
deadalnix accepted this revision.Oct 28 2019, 00:03
This revision is now accepted and ready to land.Oct 28 2019, 00:03
Closed by commit rABC46ff7d5583c1: Separate CSeederNode class declaration from definition (authored by nakihito). · Explain WhyOct 28 2019, 17:33
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC46ff7d5583c1: Separate CSeederNode class declaration from definition.
nakihito added a commit: rSTAGING46ff7d5583c1: Separate CSeederNode class declaration from definition.Apr 7 2020, 21:30

Revision Contents
Changeset List

PathSize
src/
seeder/
49 lines
557 lines

Diff 13716

View Options

src/seeder/bitcoin.h

Loading...
View Options

src/seeder/bitcoin.cpp

Loading...