Page MenuHomePhabricator

Separate CSeederNode class declaration from definition
ClosedPublic

Authored by nakihito on Oct 25 2019, 22:35.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC46ff7d5583c1: Separate CSeederNode class declaration from definition
Summary

Separating the declaration from the definition of this class to allow
unit testing in the future without having to include bitcoin.cpp.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
BreakUpBitcoincpp
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7879
Build 13773: Bitcoin ABC Buildbot (legacy)
Build 13772: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 25 2019, 22:35
Owners added a reviewer: Restricted Owners Package.Oct 25 2019, 22:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 25 2019, 22:35
nakihito planned changes to this revision.Oct 25 2019, 22:35
nakihito updated this revision to Diff 13717.Oct 25 2019, 22:37

Removed extra new line.

nakihito planned changes to this revision.Oct 25 2019, 22:37
nakihito requested review of this revision.Oct 27 2019, 00:10
deadalnix accepted this revision.Oct 28 2019, 00:03
This revision is now accepted and ready to land.Oct 28 2019, 00:03