Update qt/clientmodel.cpp to use Qt5 syntax
ClosedPublic
Actions

Authored by nakihito on Oct 29 2019, 22:05.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGfa27a36655f9: Update qt/clientmodel.cpp to use Qt5 syntax
rABCfa27a36655f9: Update qt/clientmodel.cpp to use Qt5 syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-2c51f64a3430117d2f6c7cb55355be66

Test Plan

make check
./bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7905
Build 13820: Bitcoin ABC Buildbot (legacy)
Build 13819: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 29 2019, 22:05

Owners added a reviewer: Restricted Owners Package.Oct 29 2019, 22:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2019, 22:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7905: Diff 13763.Oct 29 2019, 22:38

deadalnix accepted this revision.Oct 29 2019, 22:45

This revision is now accepted and ready to land.Oct 29 2019, 22:45

Closed by commit rABCfa27a36655f9: Update qt/clientmodel.cpp to use Qt5 syntax (authored by nakihito). · Explain WhyOct 29 2019, 23:54

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCfa27a36655f9: Update qt/clientmodel.cpp to use Qt5 syntax.

nakihito added a commit: rSTAGINGfa27a36655f9: Update qt/clientmodel.cpp to use Qt5 syntax.Apr 7 2020, 21:31

Revision Contents
Changeset List

Path

Size

src/

qt/

clientmodel.cpp

2 lines

Diff 13763

View Options

Update qt/clientmodel.cpp to use Qt5 syntaxClosedPublicActions