Update qt/coincontroldialog.cpp to use Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 29 2019, 23:33.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGc16b98ae5064: Update qt/coincontroldialog.cpp to use Qt5 connect syntax
rABCc16b98ae5064: Update qt/coincontroldialog.cpp to use Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-409074603e1373817f983557bebc15da

Test Plan

make check
./bitcoin-qt
Transactions
Right click on a transaction and select `copy address`
Send

Send some coins to yourself

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7906
Build 13822: Bitcoin ABC Buildbot (legacy)
Build 13821: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 29 2019, 23:33

Owners added a reviewer: Restricted Owners Package.Oct 29 2019, 23:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2019, 23:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7906: Diff 13764.Oct 29 2019, 23:42

deadalnix accepted this revision.Oct 30 2019, 15:31

This revision is now accepted and ready to land.Oct 30 2019, 15:31

Closed by commit rABCc16b98ae5064: Update qt/coincontroldialog.cpp to use Qt5 connect syntax (authored by nakihito). · Explain WhyOct 30 2019, 17:40

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCc16b98ae5064: Update qt/coincontroldialog.cpp to use Qt5 connect syntax.

nakihito added a commit: rSTAGINGc16b98ae5064: Update qt/coincontroldialog.cpp to use Qt5 connect syntax.Apr 7 2020, 21:32

Revision Contents
Changeset List

Path

Size

src/

qt/

coincontroldialog.cpp

75 lines

Diff 13764

View Options

src/qt/coincontroldialog.cpp

Update qt/coincontroldialog.cpp to use Qt5 connect syntaxClosedPublicActions