Paths

Table of Contentst

Update qt/receivecoinsdialog.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 21:54.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING04273600d478: Update qt/receivecoinsdialog.cpp with Qt5 connect syntax
rABC04273600d478: Update qt/receivecoinsdialog.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28?file-filters%5B%5D=.cpp#diff-dd8e54f9b8311348e3abf1ecb65eda10

Test Plan

make check
./bitcoin-qt

Open the Receive menu.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7917
Build 13844: Bitcoin ABC Buildbot (legacy)
Build 13843: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 30 2019, 21:54

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 21:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 21:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Oct 30 2019, 21:58

Harbormaster completed remote builds in B7917: Diff 13798.Oct 30 2019, 22:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Oct 31 2019, 09:40

This revision is now accepted and ready to land.Oct 31 2019, 09:40

Closed by commit rABC04273600d478: Update qt/receivecoinsdialog.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 17:12

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC04273600d478: Update qt/receivecoinsdialog.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING04273600d478: Update qt/receivecoinsdialog.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

qt/

receivecoinsdialog.cpp

30 lines

Diff 13798

View Options

src/qt/receivecoinsdialog.cpp

Update qt/receivecoinsdialog.cpp with Qt5 connect syntaxClosedPublicActions