Page MenuHomePhabricator

Various fixups for PR13557
ClosedPublic

Authored by deadalnix on Wed, Oct 30, 21:58.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf47f339d04c8: Various fixups for PR13557
Summary

PSBTInput do nto always serialize its utxo in, so the current behavior is incorrect.

Test Plan

As always, tests will come at the end of PR13557's backport.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Wed, Oct 30, 21:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Oct 30, 21:58
Fabien requested changes to this revision.Fri, Nov 1, 00:09
Fabien added a subscriber: Fabien.

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

This revision now requires changes to proceed.Fri, Nov 1, 00:09

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

It was definitively added as a mistake.

deadalnix updated this revision to Diff 13860.Fri, Nov 1, 12:29

Remove PublicOnlySigningProvider

Fabien accepted this revision.Fri, Nov 1, 15:10
This revision is now accepted and ready to land.Fri, Nov 1, 15:10
This revision was automatically updated to reflect the committed changes.