Page MenuHomePhabricator

Various fixups for PR13557
ClosedPublic

Authored by deadalnix on Oct 30 2019, 21:58.

Details

Summary

PSBTInput do nto always serialize its utxo in, so the current behavior is incorrect.

Test Plan

As always, tests will come at the end of PR13557's backport.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien requested changes to this revision.Nov 1 2019, 00:09
Fabien added a subscriber: Fabien.

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

This revision now requires changes to proceed.Nov 1 2019, 00:09

The code looks good, but the PublicOnlySigningProvider is unrelated to the title and summary of the diff.
Can you split it apart, or add some content into the summary/title ?

It was definitively added as a mistake.

Remove PublicOnlySigningProvider

This revision is now accepted and ready to land.Nov 1 2019, 15:10
This revision was automatically updated to reflect the committed changes.