Update qt/transactiontablemodel.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 23:15.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING4b0dc11a0a77: Update qt/transactiontablemodel.cpp with Qt5 connect syntax
rABC4b0dc11a0a77: Update qt/transactiontablemodel.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-cb529ae4a98c3ae9da8d7fe7d4c76c69

Test Plan

make check
./bitcoin-qt
Send -> Receive -> Transaction

Verify each sub menu opens without issue.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 30 2019, 23:15

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 23:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 23:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7929: Diff 13813.Oct 30 2019, 23:26

jasonbcox accepted this revision.Oct 30 2019, 23:53

This revision is now accepted and ready to land.Oct 30 2019, 23:53

Closed by commit rABC4b0dc11a0a77: Update qt/transactiontablemodel.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 00:11

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC4b0dc11a0a77: Update qt/transactiontablemodel.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING4b0dc11a0a77: Update qt/transactiontablemodel.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

qt/

transactiontablemodel.cpp

4 lines

Diff 13822

View Options

src/qt/transactiontablemodel.cpp

Update qt/transactiontablemodel.cpp with Qt5 connect syntaxClosedPublicActions