This diff adds the files required to setup localization for the
application bundle (lproj). There is no associated translation at the
moment, they will be added in a later diff.
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING21a33b011a58: [CMAKE] Prepare the application bundle for localization
rABC21a33b011a58: [CMAKE] Prepare the application bundle for localization
ninja BitcoinABC-Qt
The generated .app should run on OSX.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_osx_empty_translations
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8037 Build 14070: Bitcoin ABC Buildbot (legacy) Build 14069: arc lint + arc unit
Event Timeline
| src/qt/CMakeLists.txt | ||
|---|---|---|
| 320 ↗ | (On Diff #13921) | Is there a reason to join these together rather than specifying each on it's own RESOURCE line below? |
| 336 ↗ | (On Diff #13921) | The CMake documentation isn't clear on how this is handled. If it's in Resources/... why is the property not similar to RESOURCE "${BITCOINQT_BUNDLE_RESOURCES}"? Is the InfoPlist.strings a bundle and not a resource despite the location? |
| src/qt/CMakeLists.txt | ||
|---|---|---|
| 320 ↗ | (On Diff #13921) | Yes, RESOURCE takes a single argument, which can be a list. The join here is the way CMake does list serialization. |
| 336 ↗ | (On Diff #13921) | Good question :), this is a resource of the bundle just like the others. The difference is that is should be located in a subdirectory of the bundle's Resources folder (the variable is not only the file name, but the relative path). This is not possible with the standard RESOURCE property, because it will try to create the file without creating the intermediate folder first, which the MACOSX_PACKAGE_LOCATION does. |
| src/qt/CMakeLists.txt | ||
|---|---|---|
| 336 ↗ | (On Diff #13921) | Got it. thanks. |
| src/qt/CMakeLists.txt | ||
|---|---|---|
| 336 ↗ | (On Diff #13921) | Maybe consider writing that in as a comment. |