Page MenuHomePhabricator

Add a separate executible for seeder tests
AbandonedPublic

Authored by nakihito on Fri, Nov 8, 19:34.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

As requested in discussion in D4276. This allows us to run seeder unit tests
independently from the other unit tests run by test_bitcoin

Depends on D4276

Test Plan
make check
src/seeder/test_bitcoin-seeder

ninja check
ninja check-bitcoin-seeder-test

The second command should build only the seeder and the seeder tests and run
only the seeder unit tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
SeederTestsExecutable
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8035
Build 14066: Bitcoin ABC Buildbot
Build 14065: arc lint + arc unit

Event Timeline

nakihito created this revision.Fri, Nov 8, 19:34
Owners added a reviewer: Restricted Owners Package.Fri, Nov 8, 19:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 8, 19:34
jasonbcox requested changes to this revision.Fri, Nov 8, 19:42
jasonbcox added inline comments.
src/Makefile.seedertest.include
1

s/Core //g

src/seeder/CMakeLists.txt
1

while we're at it, fix the date range here too.

src/seeder/test/CMakeLists.txt
30

Should this be a module? It looks to be fairly portable to any unit test suite that we write in this repo.

src/seeder/test/seeder_tests.cpp
17

Seeing that the fixture isn't necessary, you can remove this in it's own diff.

This revision now requires changes to proceed.Fri, Nov 8, 19:42
nakihito abandoned this revision.Sat, Nov 9, 01:01

See D4417.