make check src/seeder/test_bitcoin-seeder ninja ninja check
These should build everything including the seeder and seeder tests.
This should only build test_bitcoin-seeder
This should only run the bitcoin-seeder tests.
|16 ↗||(On Diff #14019)|
This needs cleaning up. Most of those are not and will not be used in the seeder.
|1 ↗||(On Diff #14019)|
needs all three lines of the copyright
|12 ↗||(On Diff #14019)|
nit: you can leave out the dummy line. doesn't really matter as long as you remove it later though.
|8 ↗||(On Diff #14023)|
Clearly, you have a configuration problem with your text editor.
|13 ↗||(On Diff #14023)|
This whole thing is very confusing. There is a seeder target and a bitcoin-seeder one. Does that mean the seeder target contain all the logic of the seeder, at the exclusion of bitcoin specific ones? If so why does it have a bitcoin.cpp file in it?
Why is that target defined in the middle of the seeder's definition? They do not seem to even link with each other in the current state. Does this even produce a seeder that works at all?
|32 ↗||(On Diff #14023)|
This is duplicated code and calls for some refactoring.