Page MenuHomePhabricator
Differential D5328

Label length unit tests for parse_name()
ClosedPublic
Actions

Authored by nakihito on Feb 25 2020, 21:25.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9c34988e63da: Label length unit tests for parse_name()
rABC9c34988e63da: Label length unit tests for parse_name()
Summary

Adds some label length unit tests for the seeder's parse_name() function.

Depends on D4418

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Feb 25 2020, 21:25
teamcity added a comment.Feb 25 2020, 21:25

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 25 2020, 21:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9566: Diff 16502.Feb 25 2020, 21:35
nakihito added a child revision: D5329: Enforce maximum name length for parse_name() and add unit tests.Feb 25 2020, 21:48
jasonbcox requested changes to this revision.Feb 25 2020, 22:55
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
117 ↗(On Diff #16502)

You can init this all at once using what's called a "fill constructor": std::string s6a (MAX_LABEL_LENGTH, 'x'); see http://www.cplusplus.com/reference/string/string/string/

This revision now requires changes to proceed.Feb 25 2020, 22:55
jasonbcox mentioned this in D5329: Enforce maximum name length for parse_name() and add unit tests.Feb 25 2020, 22:57
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
117 ↗(On Diff #16502)

This has the added benefit of making it immediately obvious how long the string is. Making it const is even better.

nakihito updated this revision to Diff 16510.Feb 25 2020, 23:01

Removed for-loop initialization.

teamcity added a comment.Feb 25 2020, 23:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox requested changes to this revision.Feb 25 2020, 23:06
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
118 ↗(On Diff #16510)

you dont need this check anymore

This revision now requires changes to proceed.Feb 25 2020, 23:06
teamcity added a comment.Feb 25 2020, 23:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9571: Diff 16510.Feb 25 2020, 23:11
nakihito updated this revision to Diff 16512.Feb 25 2020, 23:12

Added const and removed unnecessary check.

teamcity added a comment.Feb 25 2020, 23:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9573: Diff 16512.Feb 25 2020, 23:21
teamcity added a comment.Feb 25 2020, 23:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

jasonbcox accepted this revision.Feb 26 2020, 00:53
jasonbcox added inline comments.
src/seeder/test/seeder_tests.cpp
20 ↗(On Diff #16512)

Same feedback as this comment for a future diff: https://reviews.bitcoinabc.org/D4418#inline-32872

This revision is now accepted and ready to land.Feb 26 2020, 00:53
nakihito updated this revision to Diff 16630.Feb 28 2020, 21:48

Rebased.

teamcity added a comment.Feb 28 2020, 21:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9645: Diff 16630.Feb 28 2020, 22:04
teamcity added a comment.Feb 28 2020, 22:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC9c34988e63da: Label length unit tests for parse_name() (authored by nakihito). · Explain WhyMar 2 2020, 23:14
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC9c34988e63da: Label length unit tests for parse_name().
nakihito added a commit: rSTAGING9c34988e63da: Label length unit tests for parse_name().Apr 7 2020, 23:12

Revision Contents
Changeset List

PathSize
src/
seeder/
test/
24 lines

Diff 16711

View Options

src/seeder/test/dns_tests.cpp

Loading...