Page MenuHomePhabricator

[LINTER] Fix the tests linter
ClosedPublic

Authored by Fabien on Dec 13 2019, 08:30.

Details

Summary

The test linter only works on test suites that are using the
BOOST_FIXTURE_TEST_SUITE macro, however some tests don't require any
fixture and use BOOST_AUTO_TEST_SUITE.

This diff also adds the new seeder test directory to the linter paths.

Depends on D4417.

Test Plan

Show no error:

arc lint --everything

Show both mismatch and duplicated name errors:
Copy the seeder test file with the name seeder2_tests.cpp then run:

arc lint

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 13 2019, 08:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2019, 08:30
nakihito accepted this revision.Dec 13 2019, 21:10
This revision is now accepted and ready to land.Dec 13 2019, 21:10
jasonbcox accepted this revision.Dec 14 2019, 17:35
This revision was automatically updated to reflect the committed changes.