Adds some label length unit tests for the seeder's parse_name() function.
Depends on D4418
Details
Details
- Reviewers
deadalnix Fabien jasonbcox - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project - Commits
- rSTAGING9c34988e63da: Label length unit tests for parse_name()
rABC9c34988e63da: Label length unit tests for parse_name()
ninja check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ParseNameUnitTest-4
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 9645 Build 17190: Default Diff Build & Tests Build 17189: arc lint + arc unit
Event Timeline
| src/seeder/test/seeder_tests.cpp | ||
|---|---|---|
| 117 ↗ | (On Diff #16502) | You can init this all at once using what's called a "fill constructor": std::string s6a (MAX_LABEL_LENGTH, 'x'); see http://www.cplusplus.com/reference/string/string/string/ |
| src/seeder/test/seeder_tests.cpp | ||
|---|---|---|
| 117 ↗ | (On Diff #16502) | This has the added benefit of making it immediately obvious how long the string is. Making it const is even better. |
| src/seeder/test/seeder_tests.cpp | ||
|---|---|---|
| 118 ↗ | (On Diff #16510) | you dont need this check anymore |
| src/seeder/test/seeder_tests.cpp | ||
|---|---|---|
| 20 ↗ | (On Diff #16512) | Same feedback as this comment for a future diff: https://reviews.bitcoinabc.org/D4418#inline-32872 |