Page MenuHomePhabricator
Differential D4539

Move to clang format 8
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2019, 18:08.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING0e4c4e7e50a4: Move to clang format 8
rABC0e4c4e7e50a4: Move to clang format 8
Summary

clang-format 8 is available on all systems we support and version 7 is not packaged for brew.

Test Plan
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clang-format8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8271
Build 14567: Default Diff Build & Tests
Build 14566: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 25 2019, 18:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 18:08
teamcity added a comment.Nov 25 2019, 18:51

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 19:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8271: Diff 14387.Nov 25 2019, 19:03
jasonbcox accepted this revision.Nov 25 2019, 21:11
This revision is now accepted and ready to land.Nov 25 2019, 21:11
Mengerian added a subscriber: Mengerian.Nov 25 2019, 22:15

Would be good to also update CONTRIBUTING.md with this version.

Closed by commit rABC0e4c4e7e50a4: Move to clang format 8 (authored by deadalnix). · Explain WhyNov 25 2019, 22:17
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABC0e4c4e7e50a4: Move to clang format 8.
Fabien mentioned this in D4551: Fix wrong version in clang-format error message and update the doc.Nov 26 2019, 18:57
Fabien mentioned this in rABC50f28021e062: Fix wrong version in clang-format error message and update the doc.Nov 26 2019, 20:49
deadalnix added a commit: rSTAGING0e4c4e7e50a4: Move to clang format 8.Apr 7 2020, 21:50
Fabien mentioned this in rSTAGING50f28021e062: Fix wrong version in clang-format error message and update the doc.Apr 7 2020, 21:52

Revision Contents
Changeset List

PathSize
4 lines
arcanist/
linter/
6 lines
src/
17 lines

Diff 14387

View Options

.arclint

Loading...
View Options

arcanist/linter/ClangFormatLinter.php

Loading...
View Options

src/validation.cpp

Loading...