Page MenuHomePhabricator

refactor: Add and use HaveTxsDownloaded() where appropriate
ClosedPublic

Authored by fpelliccioni on Nov 26 2019, 19:14.

Details

Summary

nChainTx is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation.

Backport of Bitcoin Core PR14863
https://github.com/bitcoin/bitcoin/pull/14863

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

fpelliccioni created this revision.Nov 26 2019, 19:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2019, 19:14
fpelliccioni edited the test plan for this revision. (Show Details)Nov 26 2019, 19:14
deadalnix accepted this revision.Nov 26 2019, 22:35
This revision is now accepted and ready to land.Nov 26 2019, 22:35
fpelliccioni updated this revision to Diff 14573.Dec 2 2019, 17:19

rebase from master