Page MenuHomePhabricator

fix undefined behaviour in seeder (select() aliasing)
ClosedPublic

Authored by markblundeberg on Mon, Dec 2, 19:43.

Details

Summary

I don't see the restrict-ness documented in man pages, but the previous
usage of select() here was triggering an aliasing warning.

../../src/seeder/bitcoin.cpp:294:36: warning: passing argument 2 to restrict-qualified parameter aliases with argument 4 [-Wrestrict]
         int ret = select(sock + 1, &set, nullptr, &set, &wa);
                                    ^~~~           ~~~~
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.