Page MenuHomePhabricator
Differential D4618

fix undefined behaviour in seeder (select() aliasing)
ClosedPublic
Actions

Authored by markblundeberg on Dec 2 2019, 19:43.

Details

Reviewers
Fabien
jasonbcox
deadalnix
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGING22a1d33378fb: fix undefined behaviour in seeder (select() aliasing)
rABC22a1d33378fb: fix undefined behaviour in seeder (select() aliasing)
Summary

I don't see the restrict-ness documented in man pages, but the previous
usage of select() here was triggering an aliasing warning.

../../src/seeder/bitcoin.cpp:294:36: warning: passing argument 2 to restrict-qualified parameter aliases with argument 4 [-Wrestrict]
         int ret = select(sock + 1, &set, nullptr, &set, &wa);
                                    ^~~~           ~~~~
Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-seeder-select
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8378
Build 14774: Default Diff Build & Tests
Build 14773: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 2 2019, 19:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 2 2019, 19:43
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 2 2019, 19:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 2 2019, 20:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8378: Diff 14581.Dec 2 2019, 20:04
markblundeberg added a comment.Dec 2 2019, 21:16

Ah OK it is documented here at least https://pubs.opengroup.org/onlinepubs/009695399/basedefs/sys/select.h.html

deadalnix accepted this revision.Dec 2 2019, 23:32
This revision is now accepted and ready to land.Dec 2 2019, 23:32
nakihito accepted this revision.Dec 3 2019, 00:42
Closed by commit rABC22a1d33378fb: fix undefined behaviour in seeder (select() aliasing) (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyDec 3 2019, 01:16
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC22a1d33378fb: fix undefined behaviour in seeder (select() aliasing).
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING22a1d33378fb: fix undefined behaviour in seeder (select() aliasing).Apr 7 2020, 21:58

Revision Contents
Changeset List

PathSize
src/
seeder/
11 lines

Diff 14581

View Options

src/seeder/bitcoin.cpp

Loading...