Page MenuHomePhabricator

Log debug build status and warn when running benchmarks
ClosedPublic

Authored by majcosta on Dec 10 2019, 19:33.

Details

Summary

"34328b4 Use PACKAGE_NAME instead of hardcoding application name in log message (Wladimir J. van der Laan)
0c74e2e Log debug build status and warn when running benchmarks (Wladimir J. van der Laan)

Pull request description:

Log whether the starting instance of bitcoin core is a debug or release build (--enable-debug).

Also warn when running the benchmarks with a debug build, to prevent mistakes comparing debug to non-debug results."

This is a backport from Core PR12197: https://github.com/bitcoin/bitcoin/pull/12197

Test Plan
cmake .. -DCMAKE_BUILD_TYPE=Debug -GNinja  
ninja check
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
backport-dec10
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8487
Build 14985: Default Diff Build & Tests
Build 14984: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 10 2019, 19:33
nakihito requested changes to this revision.Dec 10 2019, 19:59
nakihito added a subscriber: nakihito.

Test plan doesn't cover the changes. You need to build in debug mode using cmake -DCMAKE_BUILD_TYPE=Debug ... Make sure you run ninja bench-bitcoin and update your test plan as well.

This revision now requires changes to proceed.Dec 10 2019, 19:59

reverting previous code to keep divergence from Core code to a minimum

Fabien requested changes to this revision.Dec 10 2019, 21:27
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
1380 ↗(On Diff #14741)

Remove, the newlines are already printed 11 lines above due to out of order backports.

This revision now requires changes to proceed.Dec 10 2019, 21:27

removed spurious newlines

This revision is now accepted and ready to land.Dec 10 2019, 21:59