Page MenuHomePhabricator

fix some tests that misuse MANDATORY_SCRIPT_VERIFY_FLAGS
ClosedPublic

Authored by markblundeberg on Dec 12 2019, 01:54.

Details

Summary

MANDATORY_SCRIPT_VERIFY_FLAGS only exists to affect the banning behaviour
in AcceptToMemoryPool for transactions that fail to pass standard flags.
Since these tests are not about what kinds of script failures are
bannable / not bannable, they shouldn't care about what is in
MANDATORY_SCRIPT_VERIFY_FLAGS. (and such banning behaviour should in fact
be tested in the functional tests)

(cf: in Core, this flagset is only used in policy.h)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_mandatory_test
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8518
Build 15035: Default Diff Build & Tests
Build 15034: arc lint + arc unit