Page MenuHomePhabricator
Differential D4725

Add test-seeds CI configs
ClosedPublic
Actions

Authored by jasonbcox on Dec 13 2019, 20:03.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING46c4efbc432a: Add test-seeds CI configs
rABC46c4efbc432a: Add test-seeds CI configs
Summary

This will allow us to run test-seeds in an automated way on a periodic basis so that we
can be notified when the number of reachable seed nodes drops below an expected threshold.
Thresholds were chosen somewhat arbitrarily based on my personal observations during releases
(typical values are >88% for mainnet and testnet, though testnet tends to vary a bit more).

Depends on D4724

Test Plan
ABC_BUILD_NAME=check-seeds-mainnet ./build-configurations.sh
ABC_BUILD_NAME=check-seeds-testnet ./build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Dec 13 2019, 20:03
Herald added a reviewer: deadalnix. · View Herald TranscriptDec 13 2019, 20:03
teamcity added a comment.Dec 13 2019, 20:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 13 2019, 20:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8557: Diff 14853.Dec 13 2019, 20:14
Fabien requested changes to this revision.Dec 17 2019, 11:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/teamcity/check-seeds.sh
13 ↗(On Diff #14853)

I think that passing the threshold as an argument is a better solution, this is the responsibility of the caller to decide what is an acceptable value.

24 ↗(On Diff #14853)

Rather than disabling the linter, you can do this:
TOTAL=$(wc -l < "${SEED_NODES}")

This revision now requires changes to proceed.Dec 17 2019, 11:50
jasonbcox updated this revision to Diff 14928.Dec 17 2019, 19:11
jasonbcox marked an inline comment as done.

Fixed according to feedback and added help text

jasonbcox marked an inline comment as done.Dec 17 2019, 19:11
teamcity added a comment.Dec 17 2019, 19:46

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 17 2019, 20:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8604: Diff 14928.Dec 17 2019, 20:04
Fabien accepted this revision.Dec 17 2019, 21:09
Fabien added inline comments.
contrib/teamcity/check-seeds.sh
52 ↗(On Diff #14928)

Use $MAINNET and $TESTNET, or just print the help.

This revision is now accepted and ready to land.Dec 17 2019, 21:09
jasonbcox updated this revision to Diff 14937.Dec 17 2019, 21:48

Replaced hardcoded text with variables per feedback

teamcity added a comment.Dec 17 2019, 21:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox updated this revision to Diff 14938.Dec 17 2019, 21:49

Fixed updated build-configurations

teamcity added a comment.Dec 17 2019, 21:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 17 2019, 22:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8609: Diff 14938.Dec 17 2019, 22:04
teamcity added a comment.Dec 17 2019, 22:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8608: Diff 14937.Dec 17 2019, 22:08
teamcity added a comment.Dec 17 2019, 22:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 17 2019, 22:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 17 2019, 22:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Dec 17 2019, 22:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABC46c4efbc432a: Add test-seeds CI configs (authored by jasonbcox). · Explain WhyDec 17 2019, 22:46
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC46c4efbc432a: Add test-seeds CI configs.
jasonbcox mentioned this in D5314: Move check-seeds from CI to general seed tools.Feb 21 2020, 18:18
jasonbcox mentioned this in rABCfe11ff821ba7: Move check-seeds from CI to general seed tools.Feb 24 2020, 16:27
jasonbcox added a commit: rSTAGING46c4efbc432a: Add test-seeds CI configs.Apr 7 2020, 22:07
jasonbcox mentioned this in rSTAGINGfe11ff821ba7: Move check-seeds from CI to general seed tools.Apr 7 2020, 23:05

Revision Contents
Changeset List

PathSize
contrib/
teamcity/
10 lines
64 lines

Diff 14941

View Options

contrib/teamcity/build-configurations.sh

Loading...
View Options

contrib/teamcity/check-seeds.sh

Loading...