Page MenuHomePhabricator

Add test-seeds CI configs
ClosedPublic

Authored by jasonbcox on Dec 13 2019, 20:03.

Details

Summary

This will allow us to run test-seeds in an automated way on a periodic basis so that we
can be notified when the number of reachable seed nodes drops below an expected threshold.
Thresholds were chosen somewhat arbitrarily based on my personal observations during releases
(typical values are >88% for mainnet and testnet, though testnet tends to vary a bit more).

Depends on D4724

Test Plan
ABC_BUILD_NAME=check-seeds-mainnet ./build-configurations.sh
ABC_BUILD_NAME=check-seeds-testnet ./build-configurations.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
test-seeds-ci
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8609
Build 15206: Default Diff Build & Tests
Build 15205: arc lint + arc unit

Event Timeline

Fabien requested changes to this revision.Dec 17 2019, 11:50
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/teamcity/check-seeds.sh
13 ↗(On Diff #14853)

I think that passing the threshold as an argument is a better solution, this is the responsibility of the caller to decide what is an acceptable value.

24 ↗(On Diff #14853)

Rather than disabling the linter, you can do this:
TOTAL=$(wc -l < "${SEED_NODES}")

This revision now requires changes to proceed.Dec 17 2019, 11:50
jasonbcox marked an inline comment as done.

Fixed according to feedback and added help text

Fabien added inline comments.
contrib/teamcity/check-seeds.sh
52 ↗(On Diff #14928)

Use $MAINNET and $TESTNET, or just print the help.

This revision is now accepted and ready to land.Dec 17 2019, 21:09

Replaced hardcoded text with variables per feedback

Fixed updated build-configurations

This revision was automatically updated to reflect the committed changes.