Page MenuHomePhabricator
Differential D4742

Add phonon activation logic
ClosedPublic
Actions

Authored by Fabien on Dec 17 2019, 07:42.

Details

Reviewers
deadalnix
markblundeberg
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING61c538582937: Add phonon activation logic
rABC61c538582937: Add phonon activation logic
Summary

This adds the logic to check if the phonon upgrade is activated.
This is done prior to the removal of the graviton activation to allow
for adding a new argument that will trigger the next activation.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
phonon_activation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8657
Build 15300: Default Diff Build & Tests
Build 15299: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 17 2019, 07:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2019, 07:42
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 17 2019, 07:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D4743: Add a generic flag to activate the next upgrade.Dec 17 2019, 07:44
teamcity added a comment.Dec 17 2019, 07:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8584: Diff 14897.Dec 17 2019, 07:57
markblundeberg accepted this revision.Dec 17 2019, 11:02
This revision is now accepted and ready to land.Dec 17 2019, 11:02
jasonbcox accepted this revision.Dec 17 2019, 19:50
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/consensus/activation.h
35 ↗(On Diff #14897)

nit: s/may/May

Fabien updated this revision to Diff 15019.Dec 20 2019, 09:13

Rebase, fix nit.

teamcity added a comment.Dec 20 2019, 09:13

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 20 2019, 09:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8657: Diff 15019.Dec 20 2019, 09:30
Closed by commit rABC61c538582937: Add phonon activation logic (authored by Fabien). · Explain WhyDec 20 2019, 11:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC61c538582937: Add phonon activation logic.
Fabien added a commit: rSTAGING61c538582937: Add phonon activation logic.Apr 7 2020, 22:10

Revision Contents
Changeset List

PathSize
src/
consensus/
4 lines
10 lines
3 lines
test/
26 lines
5 lines

Diff 15019

View Options

src/consensus/activation.h

Loading...
View Options

src/consensus/activation.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/test/activation_tests.cpp

Loading...
View Options

src/test/test_bitcoin_main.cpp

Loading...