Differential D4755

[LINTER] Enable new autopep8 rules
ClosedPublic
Actions

Authored by Fabien on Dec 18 2019, 10:40.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING7a9dbfd6b9e9: [LINTER] Enable new autopep8 rules
rABC7a9dbfd6b9e9: [LINTER] Enable new autopep8 rules

Summary

This enables rules that are disabled by default:

E226 - Fix missing whitespace around arithmetic operator.
E241 - Fix extraneous whitespace around keywords.
E242 - Remove extraneous whitespace around operator.

This is a follow-up from this request:
https://reviews.bitcoinabc.org/D4424?id=14076#inline-27270

Test Plan

Should return no error:

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Branch

linter_autopep8_fix_spaces_around_operators

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8621
Build 15229: Default Diff Build & Tests
Build 15228: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 18 2019, 10:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2019, 10:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8621: Diff 14962.Dec 18 2019, 10:49

markblundeberg added a subscriber: markblundeberg.Dec 18 2019, 15:50

markblundeberg added inline comments.

.autopep8
3	probably better to have a newline here

Fabien added inline comments.Dec 18 2019, 15:56

.autopep8
3	Good catch

Add missing newline.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8625: Diff 14966.Dec 18 2019, 16:11

deadalnix accepted this revision.Dec 18 2019, 17:15

This revision is now accepted and ready to land.Dec 18 2019, 17:15

Closed by commit rABC7a9dbfd6b9e9: [LINTER] Enable new autopep8 rules (authored by Fabien). · Explain WhyDec 18 2019, 20:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7a9dbfd6b9e9: [LINTER] Enable new autopep8 rules.

(note that this also enabled W503, W504 which are disabled by default)

Fabien added a commit: rSTAGING7a9dbfd6b9e9: [LINTER] Enable new autopep8 rules.Apr 7 2020, 22:09

Revision Contents
Changeset List

Path

Size

.arclint

5 lines

.autopep8

2 lines

contrib/

devtools/

security-check.py

2 lines

symbol-check.py

12 lines

gitian-build.py

66 lines

testgen/

gen_base58_test_vectors.py

16 lines

test/

functional/

abc-mempool-coherence-on-activations.py

2 lines

abc-minimaldata-activation.py

2 lines

abc-schnorr.py

4 lines

abc-schnorrmultisig-activation.py

4 lines

abc-wallet-standardness.py

2 lines

feature_cltv.py

2 lines

feature_config_args.py

6 lines

feature_minchainwork.py

4 lines

interface_rest.py

2 lines

mining_prioritisetransaction.py

2 lines

p2p_unrequested_blocks.py

14 lines

rpc_createmultisig.py

2 lines

rpc_psbt.py

2 lines

rpc_rawtransaction.py

7 lines

rpc_txoutproof.py

2 lines

rpc_users.py

2 lines

test_framework/

4 lines

11 lines

14 lines

4 lines

2 lines

Diff 14962

View Options

.arclint

View Options

.autopep8

View Options

contrib/devtools/security-check.py

View Options

contrib/devtools/symbol-check.py

View Options

contrib/gitian-build.py

View Options

contrib/testgen/gen_base58_test_vectors.py

View Options

test/functional/abc-mempool-coherence-on-activations.py

View Options

test/functional/abc-minimaldata-activation.py

View Options

test/functional/abc-schnorr.py

View Options

test/functional/abc-schnorrmultisig-activation.py

View Options

test/functional/abc-wallet-standardness.py

View Options

test/functional/feature_cltv.py

View Options

test/functional/feature_config_args.py

View Options

test/functional/feature_minchainwork.py

View Options

test/functional/interface_rest.py

View Options

test/functional/mining_prioritisetransaction.py

View Options

test/functional/p2p_unrequested_blocks.py

View Options

test/functional/rpc_createmultisig.py

View Options

test/functional/rpc_psbt.py

View Options

test/functional/rpc_rawtransaction.py

View Options

test/functional/rpc_txoutproof.py

View Options

test/functional/rpc_users.py

View Options

test/functional/test_framework/blocktools.py

View Options

test/functional/test_framework/mininode.py

View Options

test/functional/test_framework/schnorr.py

View Options

test/functional/test_runner.py

View Options

test/functional/wallet_groups.py

[LINTER] Enable new autopep8 rulesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14962

.arclint

.autopep8

contrib/devtools/security-check.py

contrib/devtools/symbol-check.py

contrib/gitian-build.py

contrib/testgen/gen_base58_test_vectors.py

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-minimaldata-activation.py

test/functional/abc-schnorr.py

test/functional/abc-schnorrmultisig-activation.py

test/functional/abc-wallet-standardness.py

test/functional/feature_cltv.py

test/functional/feature_config_args.py

test/functional/feature_minchainwork.py

test/functional/interface_rest.py

test/functional/mining_prioritisetransaction.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_createmultisig.py

test/functional/rpc_psbt.py

test/functional/rpc_rawtransaction.py

test/functional/rpc_txoutproof.py

test/functional/rpc_users.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/mininode.py

test/functional/test_framework/schnorr.py

test/functional/test_runner.py

test/functional/wallet_groups.py

[LINTER] Enable new autopep8 rules
ClosedPublic
Actions

Revision Contents
Changeset List