Page MenuHomePhabricator

[LINTER] Enable new autopep8 rules
ClosedPublic

Authored by Fabien on Dec 18 2019, 10:40.

Details

Summary

This enables rules that are disabled by default:

E226 - Fix missing whitespace around arithmetic operator.
E241 - Fix extraneous whitespace around keywords.
E242 - Remove extraneous whitespace around operator.

This is a follow-up from this request:
https://reviews.bitcoinabc.org/D4424?id=14076#inline-27270

Test Plan

Should return no error:

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_autopep8_fix_spaces_around_operators
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8621
Build 15229: Default Diff Build & Tests
Build 15228: arc lint + arc unit

Event Timeline

markblundeberg added inline comments.
.autopep8
3

probably better to have a newline here

.autopep8
3

Good catch

This revision is now accepted and ready to land.Dec 18 2019, 17:15
This revision was automatically updated to reflect the committed changes.

(note that this also enabled W503, W504 which are disabled by default)