Page MenuHomePhabricator

Fixed sanitizers to compiled OK with Qt enabled
ClosedPublic

Authored by CCulianu on Aug 24 2017, 10:57.

Details

Summary

Apparently I neglected to test sanitizer support with Qt libs enabled.

It breaks because the LDFLAGS weren't specified in configure.ac.

This has been fixed now and sanitizer support should 100% work.

Note there is still an issue with TSAN (thread sanitizer) on some versions of Linux and gcc. For best results use gcc 7.x for TSAN support. Also TSAN only works on 64bit architectures.

Test Plan

./configure --enable-asan --with-gui=qt5 or whatever, then make check, then also rpc-tests.py -extended
./configure --enable-ubsan --with-gui=qt5 or whatever, then make check, then also rpc-tests.py -extended
./configure --enable-tsan --with-gui=qt5 or whatever, then make check, then also rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fixsanit
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 754
Build 754: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Aug 24 2017, 12:50
This revision was automatically updated to reflect the committed changes.