Clean up more instances of create_transaction()
ClosedPublic
Actions

Authored by nakihito on Jan 7 2020, 18:40.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING9ba3adacb152: Clean up more instances of create_transaction()
rABC9ba3adacb152: Clean up more instances of create_transaction()

Summary

These tests should be using create_tx_with_script() introduced in
D4821.

Test Plan

test_runner.py abc-p2p-compactblocks abc-p2p-fullblocktest

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Jan 7 2020, 18:40

Owners added a reviewer: Restricted Owners Package.Jan 7 2020, 18:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 7 2020, 18:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Jan 7 2020, 18:52

This revision is now accepted and ready to land.Jan 7 2020, 18:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8771: Diff 15207.Jan 7 2020, 18:59

Closed by commit rABC9ba3adacb152: Clean up more instances of create_transaction() (authored by nakihito). · Explain WhyJan 7 2020, 19:00

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC9ba3adacb152: Clean up more instances of create_transaction().

nakihito added a commit: rSTAGING9ba3adacb152: Clean up more instances of create_transaction().Apr 7 2020, 22:18

Revision Contents
Changeset List

Path

Size

test/

functional/

abc-p2p-compactblocks.py

4 lines

abc-p2p-fullblocktest.py

4 lines

Diff 15208

View Options

test/functional/abc-p2p-compactblocks.py