This is backport from PR9821 from core.
Details
Details
- Reviewers
freetrader sickpig kyuupichan CCulianu - Group Reviewers
Restricted Project - Commits
- rSTAGINGf8c812a239f1: Specific GetOSRandom for Linux/FreeBSD/OpenBSD
rABCf8c812a239f1: Specific GetOSRandom for Linux/FreeBSD/OpenBSD
make check
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Looks good, except for the attribution issue
| src/test/random_tests.cpp | ||
|---|---|---|
| 1 ↗ | (On Diff #1216) | Not preserving the original copyright notice in accordance with MIT license [1]. Original file (otherwise unmodified as far as I can see): [1] https://opensource.org/licenses/MIT:
|
Comment Actions
I like this diff. A lot.
I'll wait for others to comment but if noone approves it in a day or so I'll approve it.
| src/random.cpp | ||
|---|---|---|
| 276 ↗ | (On Diff #1216) | Heh, cute. For any random set of 32 bytes, there is a 1 in 16 chance 1 of them will be 0. However, for 1024 tries, there is a 1/(16^1024) chance all will be 0. So yeah, this test is fine. |