Page MenuHomePhabricator
Differential D490

FastRandomContext improvements and switch to ChaCha20
ClosedPublic
Actions

Authored by deadalnix on Aug 26 2017, 19:16.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGING402518c8b962: FastRandomContext improvements and switch to ChaCha20
rABC402518c8b962: FastRandomContext improvements and switch to ChaCha20
Summary

This is backport of PR9792 from core.

Depends D488

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chacharand
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 786
Build 786: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 26 2017, 19:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 26 2017, 19:16
Harbormaster completed remote builds in B764: Diff 1220.Aug 26 2017, 19:16
CCulianu edited edge metadata.Aug 27 2017, 10:15

I can't apply this patch to test it.

And this patch is a prerequisite for D491.

I am not sure what HEAD you're working off of, but can you try and keep the patches off of master so that they apply?

deadalnix updated this revision to Diff 1239.Aug 27 2017, 12:56

rebase

Harbormaster completed remote builds in B778: Diff 1239.Aug 27 2017, 12:56
freetrader requested changes to this revision.Aug 28 2017, 11:36

Checked that the backport is accurate, but please fix the attribution instances

src/crypto/chacha20.cpp
1 ↗(On Diff #1239)

correct attribution please

src/crypto/chacha20.h
1 ↗(On Diff #1239)

correct attribution please

This revision now requires changes to proceed.Aug 28 2017, 11:36
deadalnix updated this revision to Diff 1248.Aug 28 2017, 12:56
deadalnix edited edge metadata.

Change attribution.

freetrader accepted this revision.Aug 28 2017, 13:07
This revision is now accepted and ready to land.Aug 28 2017, 13:07
Closed by commit rABC402518c8b962: FastRandomContext improvements and switch to ChaCha20 (authored by deadalnix, committed by deadalnix). · Explain WhyAug 28 2017, 13:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
src/
2 lines
11 lines
27 lines
bench/
2 lines
23 lines
crypto/
25 lines
190 lines
23 lines
2 lines
78 lines
33 lines
test/
9 lines
78 lines
8 lines
34 lines
3 lines
8 lines
wallet/
2 lines

Diff 1248

View Options

configure.ac

Loading...
View Options

src/Makefile.am

Loading...
View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...
View Options

src/bench/checkqueue.cpp

Loading...
View Options

src/bench/crypto_hash.cpp

Loading...
View Options

src/crypto/chacha20.h

Loading...
View Options

src/crypto/chacha20.cpp

Loading...
View Options

src/crypto/common.h

Loading...
View Options

src/net.h

Loading...
View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...
View Options

src/test/addrman_tests.cpp

Loading...
View Options

src/test/crypto_tests.cpp

Loading...
View Options

src/test/prevector_tests.cpp

Loading...
View Options

src/test/random_tests.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/test/test_random.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...