Page MenuHomePhabricator

Merge #13861: test: Add testing of value_ret for SelectCoinsBnB
ClosedPublic

Authored by nakihito on Jan 16 2020, 19:56.

Details

Summary

384273260a6ccbcf79dade0830011f528e5a1581 test: Add testing of value_ret for SelectCoinsBnB (Ben Woosley)

Pull request description:

Fix that the early bailout optimization tests did not test the intended
selection because their utxo pool was polluted by the make_hard_case test
preceding. Note the code was tested, just not with the constructed case.

Tree-SHA512: 95f665525f5922f70f4c17708c0c09900f38d7a652b5bdd817e017ba7ff2865a6234edbd340064ffccc20d34048c45df86a4ac5f46dd8f4aab98834e71dc9d3c

Backport of Core PR13861
https://github.com/bitcoin/bitcoin/pull/13861/

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13861
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8983
Build 15929: Default Diff Build & Tests
Build 15928: arc lint + arc unit