Page MenuHomePhabricator
Differential D4965

Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args
ClosedPublic
Actions

Authored by nakihito on Jan 16 2020, 22:49.

Details

Reviewers
deadalnix
Fabien
jasonbcox
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded…
rABCfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded…
Summary

1e29379d69 Fix potential deadlock (practicalswift)
d58dc9f943 Add lock annotations (cs_args) (practicalswift)
db5e9d3c88 Add missing locks (cs_args) (practicalswift)

Pull request description:

  • Add missing cs_args locks
  • Add Clang thread safety annotations for variables guarded by cs_args

Tree-SHA512: bc562dbddf24a287bcf9bf902bc930f942f260a94e5c8ec4d190f7f2ddac448ed3d52acadaf9fc1c81a5cbff2c171c52c18ba0804eeb03f699d70394e1c977c5

Backport of Core PR13126
https://github.com/bitcoin/bitcoin/pull/13126/

Completes T652

Test Plan
cmake -GNinja .. -DENABLE_WERROR=ON
ninja check

Also run build-werror and build-tsan builds.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Jan 16 2020, 22:49
Owners added a reviewer: Restricted Owners Package.Jan 16 2020, 22:49
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2020, 22:49
nakihito planned changes to this revision.Jan 16 2020, 22:49
teamcity added a comment.Jan 16 2020, 22:49

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 16 2020, 22:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 16 2020, 22:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Jan 16 2020, 23:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8987: Diff 15537.Jan 16 2020, 23:06
nakihito requested review of this revision.Jan 16 2020, 23:06
jasonbcox requested changes to this revision.Jan 16 2020, 23:20

werror doesn't test anything interesting here. What you want is TSAN (thread sanitizer)

This revision now requires changes to proceed.Jan 16 2020, 23:20
jasonbcox added a subscriber: markblundeberg.Jan 16 2020, 23:25
jasonbcox added inline comments.
src/util/system.cpp
948 ↗(On Diff #15537)

https://reviews.bitcoinabc.org/D3035#inline-18705
@markblundeberg
@Fabien
FYI

teamcity added a comment.Jan 16 2020, 23:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Jan 16 2020, 23:27
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Jan 16 2020, 23:34

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito requested review of this revision.Jan 16 2020, 23:35
nakihito added a reviewer: markblundeberg.
jasonbcox accepted this revision.Jan 16 2020, 23:41
This revision is now accepted and ready to land.Jan 16 2020, 23:41
teamcity added a comment.Jan 16 2020, 23:47

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 16 2020, 23:55

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Closed by commit rABCfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded… (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyJan 17 2020, 19:22
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded….
nakihito added a commit: rSTAGINGfd82b9f9f31c: Merge #13126: util: Add Clang thread safety annotations for variables guarded….Apr 7 2020, 22:33

Revision Contents
Changeset List

PathSize
src/
util/
18 lines
13 lines

Diff 15617

View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...