Page MenuHomePhabricator

Merge #13126: util: Add Clang thread safety annotations for variables guarded by cs_args
ClosedPublic

Authored by nakihito on Jan 16 2020, 22:49.

Details

Summary

1e29379d69 Fix potential deadlock (practicalswift)
d58dc9f943 Add lock annotations (cs_args) (practicalswift)
db5e9d3c88 Add missing locks (cs_args) (practicalswift)

Pull request description:

  • Add missing cs_args locks
  • Add Clang thread safety annotations for variables guarded by cs_args

Tree-SHA512: bc562dbddf24a287bcf9bf902bc930f942f260a94e5c8ec4d190f7f2ddac448ed3d52acadaf9fc1c81a5cbff2c171c52c18ba0804eeb03f699d70394e1c977c5

Backport of Core PR13126
https://github.com/bitcoin/bitcoin/pull/13126/

Completes T652

Test Plan
cmake -GNinja .. -DENABLE_WERROR=ON
ninja check

Also run build-werror and build-tsan builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13126
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8987
Build 15936: Default Diff Build & Tests
Build 15935: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Jan 16 2020, 22:49
jasonbcox requested changes to this revision.Jan 16 2020, 23:20

werror doesn't test anything interesting here. What you want is TSAN (thread sanitizer)

This revision now requires changes to proceed.Jan 16 2020, 23:20
nakihito edited the test plan for this revision. (Show Details)
nakihito added a reviewer: markblundeberg.
This revision is now accepted and ready to land.Jan 16 2020, 23:41