Fix error codes from various RPCs
ClosedPublic
Actions

Authored by deadalnix on Aug 27 2017, 20:06.

Details

Reviewers

freetrader
CCulianu

Group Reviewers

Restricted Project

Commits

rSTAGINGc44b0bb58eec: Fix error codes from various RPCs
rABCc44b0bb58eec: Fix error codes from various RPCs

Summary

This is backport of PR9853 from core.

Test Plan

../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

rpccode

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 782
Build 782: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 27 2017, 20:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 27 2017, 20:06

Harbormaster completed remote builds in B782: Diff 1243.Aug 27 2017, 20:06

deadalnix mentioned this in D499: [qa] Add logging to test_framework.py.Aug 27 2017, 20:36

It would be very helpful to port also the applicable release notes "Low-level RPC changes" which was part of the PR9853.
Simply referring to PR9853 in the release notes would not be very useful because some of the affected RPC calls mentioned there are not applicable to ABC (e.g. 'bumpfee').

The changes seem good otherwise.

freetrader mentioned this in D503: Add low-level RPC error code changes from D500 to release notes.Aug 28 2017, 13:01

Accepting , the release notes updates have been added in D503.

This revision is now accepted and ready to land.Aug 28 2017, 13:01

Closed by commit rABCc44b0bb58eec: Fix error codes from various RPCs (authored by deadalnix, committed by deadalnix). · Explain WhyAug 28 2017, 13:09

This revision was automatically updated to reflect the committed changes.

freetrader mentioned this in rABC9f2d65cb7915: Add low-level RPC error code changes from D500 to release notes.Aug 28 2017, 13:10