Page MenuHomePhabricator
Differential D5015

simplify ATMP standard flag computation [2/2] - move computation to another function
ClosedPublic
Actions

Authored by markblundeberg on Jan 18 2020, 11:04.

Details

Reviewers
Mengerian
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3e255713bfa6: simplify ATMP standard flag computation [2/2] - move computation to another…
rABC3e255713bfa6: simplify ATMP standard flag computation [2/2] - move computation to another…
Summary

The functional form here is entirely based on GetNextBlockScriptFlags.

(Note: This should entirely remove the need for IsXEnabledForCurrentBlock
functions in future upgrades.)

Depends on D5014

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
simplify-checkinputs-flags
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9050
Build 16062: Default Diff Build & Tests
Build 16061: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Jan 18 2020, 11:04
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2020, 11:04
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Jan 18 2020, 11:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 18 2020, 11:11

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9050: Diff 15648.Jan 18 2020, 11:11
markblundeberg added inline comments.Jan 18 2020, 11:23
src/validation.cpp
1555

Other function here, for comparison.

markblundeberg added a child revision: D5018: add input sigchecks limit to STANDARD_SCRIPT_VERIFY_FLAGS (but not mempool flags).Jan 18 2020, 12:15
deadalnix accepted this revision.Jan 18 2020, 23:33
This revision is now accepted and ready to land.Jan 18 2020, 23:33
Closed by commit rABC3e255713bfa6: simplify ATMP standard flag computation [2/2] - move computation to another… (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyJan 19 2020, 02:12
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC3e255713bfa6: simplify ATMP standard flag computation [2/2] - move computation to another….
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING3e255713bfa6: simplify ATMP standard flag computation [2/2] - move computation to another….Apr 7 2020, 22:34

Revision Contents
Changeset List

PathSize
src/
27 lines

Diff 15648

View Options

src/validation.cpp

Loading...