Paths

Table of Contentst

Differential D5033

[SECP256K1] Use the cmake version from Kitware PPA on Travis
ClosedPublic
Actions

Authored by Fabien on Jan 21 2020, 09:26.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING65c1f116deed: [SECP256K1] Use the cmake version from Kitware PPA on Travis
rABC65c1f116deed: [SECP256K1] Use the cmake version from Kitware PPA on Travis

Summary

This PPA is well maintained by Kitware, and is often updated to the
latest version. This will allow to bump the version requirement past the
Travis version (currently 3.12).

Note: this fix an issue with list(SORT) that would fail on empty lists
with cmake < 3.13. The minimum version will be bumped in a later diff to
enforce this fix.

Test Plan

Run the Travis build, and check the cmake version in use is the one from
the PPA. See the build on repo (failure will be fixed in another diff):
https://travis-ci.org/Fabcien/secp256k1/builds/639851517

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 21 2020, 09:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 21 2020, 09:26

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9087: Diff 15703.Jan 21 2020, 09:30

Fabien added a child revision: D5034: [CMAKE] Fix the native build when the target is in the current build dir.Jan 21 2020, 09:36

Missing 32 bit version

Fabien added a child revision: D5035: [CMAKE] Bump minimum version to 3.13.Jan 21 2020, 10:34

Fix 32 bits build.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien mentioned this in D5036: [CMAKE] Don't sort empty list.Jan 21 2020, 12:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9091: Diff 15707.Jan 21 2020, 12:07

deadalnix accepted this revision.Jan 21 2020, 13:57

This revision is now accepted and ready to land.Jan 21 2020, 13:57

Closed by commit rABC65c1f116deed: [SECP256K1] Use the cmake version from Kitware PPA on Travis (authored by Fabien). · Explain WhyJan 21 2020, 14:27

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC65c1f116deed: [SECP256K1] Use the cmake version from Kitware PPA on Travis.

Fabien added a commit: rSTAGING65c1f116deed: [SECP256K1] Use the cmake version from Kitware PPA on Travis.Apr 7 2020, 22:36

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

21 lines

travis/

6 lines

Diff 15711

src/secp256k1/.travis.yml

Loading...

src/secp256k1/travis/build_cmake.sh

Loading...