Page MenuHomePhabricator
Differential D5075

Remove uses of cs_main in wallet code
ClosedPublic
Actions

Authored by Fabien on Jan 27 2020, 11:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGced2e736ff23: Remove uses of cs_main in wallet code
rABCced2e736ff23: Remove uses of cs_main in wallet code
Summary

This commit does not change behavior.

Partial backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/79d579f4e11b57f90fed314bccd25230f918729f

Depends on D5063 and D5074.

Test Plan
cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check check-functional

Run the CI TSAN build configuration.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14437_part3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9151
Build 16260: Default Diff Build & Tests
Build 16259: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 27 2020, 11:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2020, 11:08
teamcity edited the summary of this revision. (Show Details)Jan 27 2020, 11:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 27 2020, 11:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Jan 27 2020, 11:11
teamcity added a comment.Jan 27 2020, 11:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9151: Diff 15806.Jan 27 2020, 11:14
teamcity added a comment.Jan 27 2020, 11:20

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Jan 27 2020, 11:28

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Fabien added a child revision: D5078: Pass chain locked variables where needed.Jan 27 2020, 14:02
deadalnix accepted this revision.Jan 27 2020, 16:14
This revision is now accepted and ready to land.Jan 27 2020, 16:14
Closed by commit rABCced2e736ff23: Remove uses of cs_main in wallet code (authored by Russell Yanofsky <russ@yanofsky.org>, committed by Fabien). · Explain WhyJan 27 2020, 17:05
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCced2e736ff23: Remove uses of cs_main in wallet code.
Fabien added a commit: rSTAGINGced2e736ff23: Remove uses of cs_main in wallet code.Apr 7 2020, 22:40
nakihito mentioned this in D6302: Merge #12330: Reduce scope of cs_wallet locks in listtransactions.May 29 2020, 23:28

Revision Contents
Changeset List

PathSize
src/
interfaces/
19 lines
29 lines
55 lines
qt/
test/
2 lines
wallet/
30 lines
111 lines
test/
13 lines
75 lines

Diff 15806

View Options

src/interfaces/chain.h

Loading...
View Options

src/interfaces/chain.cpp

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...