Page MenuHomePhabricator
Differential D5194

add E711 to python linter (reject `== None` / `!= None`)
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 11:43.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING616b8bdfa9c4: add E711 to python linter (reject `== None` / `!= None`)
rABC616b8bdfa9c4: add E711 to python linter (reject `== None` / `!= None`)
Summary

(quasi-backport of PR14903)

Test Plan
ninja check-functional
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
flake_E711
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9322
Build 16580: Default Diff Build & Tests
Build 16579: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 7 2020, 11:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 11:43
teamcity edited the summary of this revision. (Show Details)Feb 7 2020, 11:43

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 7 2020, 11:43

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 7 2020, 11:46

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

Fabien accepted this revision.Feb 7 2020, 11:47
This revision is now accepted and ready to land.Feb 7 2020, 11:47
teamcity added a comment.Feb 7 2020, 12:06

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9322: Diff 16104.Feb 7 2020, 12:06
teamcity added a comment.Feb 7 2020, 12:07

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Closed by commit rABC616b8bdfa9c4: add E711 to python linter (reject `== None` / `!= None`) (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 12:10
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC616b8bdfa9c4: add E711 to python linter (reject `== None` / `!= None`).
markblundeberg added a child revision: D5198: [python linting] enforce all flake8 E & W codes besides some exceptions.Feb 7 2020, 14:37
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING616b8bdfa9c4: add E711 to python linter (reject `== None` / `!= None`).Apr 7 2020, 22:52

Revision Contents
Changeset List

Diff 16104

View Options

.arclint

Loading...
View Options

contrib/devtools/copyright_header.py

Loading...
View Options

test/functional/abc-invalid-chains.py

Loading...
View Options

test/functional/abc-mempool-accept-txn.py

Loading...
View Options

test/functional/abc-mempool-coherence-on-activations.py

Loading...
View Options

test/functional/abc-p2p-compactblocks.py

Loading...
View Options

test/functional/abc-p2p-fullblocktest-sigops.py

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...
View Options

test/functional/abc-replay-protection.py

Loading...
View Options

test/functional/abc-segwit-recovery.py

Loading...
View Options

test/functional/abc-transaction-ordering.py

Loading...
View Options

test/functional/interface_http.py

Loading...
View Options

test/functional/mining_prioritisetransaction.py

Loading...
View Options

test/functional/test_framework/blocktools.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...
View Options

test/functional/test_runner.py

Loading...