Page MenuHomePhabricator
Differential D5199

[python linting] enforce E265: Block comment should start with '# '
ClosedPublic
Actions

Authored by markblundeberg on Feb 7 2020, 15:00.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGe49bf3130e7d: [python linting] enforce E265: Block comment should start with '# '
rABCe49bf3130e7d: [python linting] enforce E265: Block comment should start with '# '
Summary

Depends on D5198

Test Plan

ninja check-all
arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
lintfixes
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9327
Build 16590: Default Diff Build & Tests
Build 16589: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 7 2020, 15:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 15:00
teamcity added a comment.Feb 7 2020, 15:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Feb 7 2020, 15:11
This revision is now accepted and ready to land.Feb 7 2020, 15:11
markblundeberg added a child revision: D5200: [python linting] enforce E712: Comparison to true should be 'if cond is true:' or 'if cond:'.Feb 7 2020, 15:14
teamcity added a comment.Feb 7 2020, 15:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9327: Diff 16115.Feb 7 2020, 15:22
Closed by commit rABCe49bf3130e7d: [python linting] enforce E265: Block comment should start with '# ' (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 7 2020, 15:49
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCe49bf3130e7d: [python linting] enforce E265: Block comment should start with '# '.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGe49bf3130e7d: [python linting] enforce E265: Block comment should start with '# '.Apr 7 2020, 22:52
• Munna123 added a subscriber: • Munna123.Jul 29 2020, 10:00
This comment was removed by Mengerian.
• hannahberry added a subscriber: • hannahberry.Aug 17 2020, 09:45
This comment was removed by Mengerian.
• Munna123 added a comment.Jun 26 2021, 08:25
This comment was removed by Mengerian.
Mengerian added a subscriber: Mengerian.Jun 26 2021, 15:53

Revision Contents
Changeset List

PathSize
2 lines
test/
functional/
2 lines
2 lines

Diff 16115

View Options

.arclint

Loading...
View Options

test/functional/wallet_abandonconflict.py

Loading...
View Options

test/functional/wallet_hd.py

Loading...