Page MenuHomePhabricator
Differential D5207

qa: Prevent concurrency issues reading .cookie file
ClosedPublic
Actions

Authored by Fabien on Feb 7 2020, 17:38.

Details

Reviewers
jasonbcox
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGdb11d6bfc86a: qa: Prevent concurrency issues reading .cookie file
rABCdb11d6bfc86a: qa: Prevent concurrency issues reading .cookie file
Summary

Backport of core PR15771 (and PR14788).

This is expected to fix the TSAN errors like
https://build.bitcoinabc.org/viewLog.html?buildTypeId=BitcoinABC_ResourceIntensiveBuilds_BitcoinAbcMasterTsan&buildId=28539.

Test Plan

Run the CI TSAN build.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15771
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9337
Build 16610: Default Diff Build & Tests
Build 16609: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 7 2020, 17:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 7 2020, 17:38
teamcity edited the summary of this revision. (Show Details)Feb 7 2020, 17:38

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 7 2020, 17:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox accepted this revision.Feb 7 2020, 17:40
This revision is now accepted and ready to land.Feb 7 2020, 17:40
markblundeberg accepted this revision.Feb 7 2020, 17:40
teamcity added a comment.Feb 7 2020, 17:43

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9337: Diff 16134.Feb 7 2020, 17:43
Closed by commit rABCdb11d6bfc86a: qa: Prevent concurrency issues reading .cookie file (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyFeb 7 2020, 18:11
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCdb11d6bfc86a: qa: Prevent concurrency issues reading .cookie file.
Fabien added a commit: rSTAGINGdb11d6bfc86a: qa: Prevent concurrency issues reading .cookie file.Apr 7 2020, 22:53

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
4 lines

Diff 16134

View Options

test/functional/test_framework/util.py

Loading...