[python linting] apply aggressive mode in autopep8 (line wrapping)
ClosedPublic
Actions

Authored by markblundeberg on Feb 8 2020, 01:23.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING26a48be39823: [python linting] apply aggressive mode in autopep8 (line wrapping)
rABC26a48be39823: [python linting] apply aggressive mode in autopep8 (line wrapping)

Summary

This adds the aggressive mode and then applies all sugggested
changes. Also I've removed the .autopep8 file, as I think it's
better to put things in the arclint file.

These are all just whitespace changes.

To fully reproduce these changes, install autopep8 1.5 and pycodestyle 2.5.0 (most
recent) which catches a few more things than the linux distro
versions. Older versions are happy with the result, but they
will suggest slightly fewer changes it seems.

Depends on D5215 D5216

Test Plan

ninja check-extended
arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Branch

autopep8-reag3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9349
Build 16630: Default Diff Build & Tests
Build 16629: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 8 2020, 01:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2020, 01:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

markblundeberg edited the summary of this revision. (Show Details)Feb 8 2020, 01:27

Harbormaster completed remote builds in B9349: Diff 16161.Feb 8 2020, 01:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

markblundeberg edited the summary of this revision. (Show Details)Feb 8 2020, 01:41

deadalnix accepted this revision.Feb 8 2020, 01:54

This revision is now accepted and ready to land.Feb 8 2020, 01:54

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

markblundeberg edited the test plan for this revision. (Show Details)Feb 8 2020, 02:16

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing passed.

Closed by commit rABC26a48be39823: [python linting] apply aggressive mode in autopep8 (line wrapping) (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyFeb 8 2020, 02:41

This revision was automatically updated to reflect the committed changes.

Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABC26a48be39823: [python linting] apply aggressive mode in autopep8 (line wrapping).

markblundeberg added a child revision: D5219: [python linting] tweak options.Feb 8 2020, 04:21

Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGING26a48be39823: [python linting] apply aggressive mode in autopep8 (line wrapping).Apr 7 2020, 22:54

Revision Contents
Changeset List

Path

Size

.arclint

3 lines

.autopep8

contrib/

devtools/

chainparams/

test_make_chainparams.py

6 lines

circular-dependencies.py

6 lines

copyright_header.py

78 lines

optimize-pngs.py

3 lines

security-check.py

6 lines

update-translations.py

25 lines

gitian-build.py

6 lines

linearize/

linearize-data.py

9 lines

linearize-hashes.py

7 lines

seeds/

makeseeds.py

6 lines

testgen/

gen_base58_test_vectors.py

3 lines

share/

qt/

extract_strings_qt.py

4 lines

test/

functional/

abc-finalize-block.py

6 lines

abc-invalid-message.py

3 lines

abc-mempool-accept-txn.py

6 lines

abc-mempool-coherence-on-activations.py

6 lines

abc-p2p-compactblocks.py

12 lines

abc-p2p-fullblocktest-sigops.py

12 lines

abc-p2p-fullblocktest.py

12 lines

abc-schnorr.py

6 lines

abc-sigops-mempool-mining.py

6 lines

abc-transaction-ordering.py

6 lines

combine_logs.py

9 lines

example_test.py

15 lines

feature_assumevalid.py

9 lines

feature_bip68_sequence.py

6 lines

feature_block.py

30 lines

feature_block_sigops.py

26 lines

feature_cltv.py

3 lines

feature_csv_activation.py

36 lines

feature_dbcrash.py

9 lines

feature_notifications.py

10 lines

12 lines

9 lines

19 lines

3 lines

18 lines

9 lines

6 lines

9 lines

mining_getblocktemplate_longpoll.py

3 lines

p2p_compactblocks.py

9 lines

p2p_invalid_tx.py

6 lines

p2p_leak.py

3 lines

p2p_node_network_limited.py

9 lines

p2p_sendheaders.py

21 lines

p2p_unrequested_blocks.py

21 lines

rpc_bind.py

3 lines

rpc_blockchain.py

3 lines

rpc_estimatefee.py

3 lines

rpc_fundrawtransaction.py

3 lines

rpc_getblockstats.py

6 lines

rpc_net.py

3 lines

rpc_psbt.py

3 lines

rpc_rawtransaction.py

15 lines

rpc_txoutproof.py

6 lines

test_framework/

9 lines

6 lines

18 lines

17 lines

19 lines

15 lines

15 lines

21 lines

3 lines

25 lines

27 lines

wallet_abandonconflict.py

16 lines

wallet_basic.py

29 lines

wallet_hd.py

6 lines

wallet_importmulti.py

6 lines

wallet_keypool.py

3 lines

wallet_listreceivedby.py

15 lines

wallet_listsinceblock.py

3 lines

wallet_multiwallet.py

12 lines

wallet_resendwallettransactions.py

3 lines

wallet_txn_doublespend.py

3 lines

wallet_zapwallettxes.py

9 lines

lint/

check-rpc-mappings.py

3 lines

lint-format-strings.py

12 lines

lint-python-format.py

3 lines

[python linting] apply aggressive mode in autopep8 (line wrapping)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 16161

.arclint

.autopep8

contrib/devtools/chainparams/test_make_chainparams.py

contrib/devtools/circular-dependencies.py

contrib/devtools/copyright_header.py

contrib/devtools/optimize-pngs.py

contrib/devtools/security-check.py

contrib/devtools/update-translations.py

contrib/gitian-build.py

contrib/linearize/linearize-data.py

contrib/linearize/linearize-hashes.py

contrib/seeds/makeseeds.py

contrib/testgen/gen_base58_test_vectors.py

share/qt/extract_strings_qt.py

test/functional/abc-finalize-block.py

test/functional/abc-invalid-message.py

test/functional/abc-mempool-accept-txn.py

test/functional/abc-mempool-coherence-on-activations.py

test/functional/abc-p2p-compactblocks.py

test/functional/abc-p2p-fullblocktest-sigops.py

test/functional/abc-p2p-fullblocktest.py

test/functional/abc-schnorr.py

test/functional/abc-sigops-mempool-mining.py

test/functional/abc-transaction-ordering.py

test/functional/combine_logs.py

test/functional/example_test.py

test/functional/feature_assumevalid.py

test/functional/feature_bip68_sequence.py

test/functional/feature_block.py

test/functional/feature_block_sigops.py

test/functional/feature_cltv.py

test/functional/feature_csv_activation.py

test/functional/feature_dbcrash.py

test/functional/feature_notifications.py

test/functional/feature_pruning.py

test/functional/interface_rest.py

test/functional/mempool_accept.py

test/functional/mempool_limit.py

test/functional/mempool_packages.py

test/functional/mempool_persist.py

test/functional/mempool_reorg.py

test/functional/mining_basic.py

test/functional/mining_getblocktemplate_longpoll.py

test/functional/p2p_compactblocks.py

test/functional/p2p_invalid_tx.py

test/functional/p2p_leak.py

test/functional/p2p_node_network_limited.py

test/functional/p2p_sendheaders.py

test/functional/p2p_unrequested_blocks.py

test/functional/rpc_bind.py

test/functional/rpc_blockchain.py

test/functional/rpc_estimatefee.py

test/functional/rpc_fundrawtransaction.py

test/functional/rpc_getblockstats.py

test/functional/rpc_net.py

test/functional/rpc_psbt.py

test/functional/rpc_rawtransaction.py

test/functional/rpc_txoutproof.py

test/functional/test_framework/authproxy.py

test/functional/test_framework/blocktools.py

test/functional/test_framework/key.py

test/functional/test_framework/messages.py

test/functional/test_framework/mininode.py

test/functional/test_framework/script.py

test/functional/test_framework/test_framework.py

test/functional/test_framework/test_node.py

test/functional/test_framework/txtools.py

test/functional/test_framework/util.py

test/functional/test_runner.py

test/functional/wallet_abandonconflict.py

test/functional/wallet_basic.py

test/functional/wallet_hd.py

test/functional/wallet_importmulti.py

test/functional/wallet_keypool.py

[python linting] apply aggressive mode in autopep8 (line wrapping)
ClosedPublic
Actions

Revision Contents
Changeset List