Merge #14310: [wallet] Ensure wallet is unlocked before signing
ClosedPublic
Actions

Authored by nakihito on Feb 12 2020, 01:00.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing
rABCddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing

Summary

20442f617f [wallet] remove redundand restart node (gustavonalle)
db15805668 [wallet] Ensure wallet is unlocked before signing (gustavonalle)

Pull request description:

Fixes #14082

Tree-SHA512: 200620a2ced934f958933aba34541565a992e5033cf04c4e2be48b99e7708973c85f8274968962cec943f0c1d76fb2faa5e056469bbf59ce7f768614572322f9

Backport of Core PR14310
https://github.com/bitcoin/bitcoin/pull/14310/

Test Plan

cmake -GNinja .. -DCMAKE_BUILD_TYPE=Debug
ninja check
ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14310

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9453
Build 16827: Default Diff Build & Tests
Build 16826: arc lint + arc unit

Event Timeline

nakihito created this revision.Feb 12 2020, 01:00

Owners added a reviewer: Restricted Owners Package.Feb 12 2020, 01:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 12 2020, 01:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

jasonbcox accepted this revision.Feb 12 2020, 01:04

This revision is now accepted and ready to land.Feb 12 2020, 01:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9453: Diff 16313.Feb 12 2020, 01:10

Closed by commit rABCddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyFeb 12 2020, 01:21

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABCddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing.

nakihito added a commit: rSTAGINGddcbef8bf4b3: Merge #14310: [wallet] Ensure wallet is unlocked before signing.Apr 7 2020, 22:58

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpcwallet.cpp

2 lines

test/

functional/

rpc_signrawtransaction.py

12 lines

Diff 16313

View Options

src/wallet/rpcwallet.cpp