Check transaction that enter the mempool against the flags required for the current block rather than a minimal set of mandatory flags.
ClosedPublic
Actions

Authored by deadalnix on Sep 5 2017, 20:01.

Details

Reviewers

freetrader
CCulianu
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGING7c7aa1738d19: Check transaction that enter the mempool against the flags required for the…
rABC7c7aa1738d19: Check transaction that enter the mempool against the flags required for the…

Summary

This is based on work by Matt Coralo. We shouldn't accept in the mempool any transaction that won't be valid if mined.

Depends on D520, D526

Test Plan

make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mempoolcheck

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 850
Build 850: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 5 2017, 20:01

Harbormaster completed remote builds in B834: Diff 1320.Sep 5 2017, 20:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2017, 20:01

Do not print scary warning message when promiscuousmempoolflags is used.

Harbormaster completed remote builds in B840: Diff 1329.Sep 6 2017, 10:23

deadalnix added a child revision: D530: Cache script execution on a per transaction basis.Sep 6 2017, 12:22

Rebase

Harbormaster completed remote builds in B850: Diff 1351.Sep 7 2017, 19:27

dagurval accepted this revision.Sep 7 2017, 20:16

This revision is now accepted and ready to land.Sep 7 2017, 20:16

Closed by commit rABC7c7aa1738d19: Check transaction that enter the mempool against the flags required for the… (authored by deadalnix, committed by deadalnix). · Explain WhySep 7 2017, 23:14

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

43 lines

Diff 1351

View Options

Check transaction that enter the mempool against the flags required for the current block rather than a minimal set of mandatory flags.ClosedPublicActions