Page MenuHomePhabricator

Check transaction that enter the mempool against the flags required for the current block rather than a minimal set of mandatory flags.
ClosedPublic

Authored by deadalnix on Sep 5 2017, 20:01.

Details

Summary

This is based on work by Matt Coralo. We shouldn't accept in the mempool any transaction that won't be valid if mined.

Depends on D520, D526

Test Plan
make check
../qa/pull-tester/rpc-tests.py -extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 5 2017, 20:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 5 2017, 20:01
deadalnix updated this revision to Diff 1329.Sep 6 2017, 10:23

Do not print scary warning message when promiscuousmempoolflags is used.

dagurval accepted this revision.Sep 7 2017, 20:16
This revision is now accepted and ready to land.Sep 7 2017, 20:16
This revision was automatically updated to reflect the committed changes.