Page MenuHomePhabricator

Move build_* wrapper scripts to devtools
ClosedPublic

Authored by jasonbcox on Feb 14 2020, 20:06.

Details

Summary

In a discussion regarding D5270, it become clear that a inserting a dependency where automated commit jobs
rely on part of the CI code was confusing and setting a bad precedent.

While these wrapper scripts are used heavily by Teamcity (CI), their use is not limited to CI, so I've moved
them to devtools, which seems more appropriate. There is precedent for this already, as CI and automated-commits
have depenendencies on devtools,

Test Plan

Run a bunch of tests on CI to make sure everything is still working.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
build-devtools
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9501
Build 16915: Default Diff Build & Tests
Build 16914: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 17 2020, 13:39
This revision was automatically updated to reflect the committed changes.