Page MenuHomePhabricator
Differential D5386

Stop using the deprecated google::protobuf::MessageLite::ByteSize()
ClosedPublic
Actions

Authored by majcosta on Feb 29 2020, 17:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING40e56e8fcc93: Stop using the deprecated google::protobuf::MessageLite::ByteSize()
rABC40e56e8fcc93: Stop using the deprecated google::protobuf::MessageLite::ByteSize()
Summary

from build logs:

‘int google::protobuf::MessageLite::ByteSize() const’ is deprecated: Please use ByteSizeLong() instead [-Wdeprecated-declarations]'

https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.message_lite#MessageLite.ByteSizeLong.details

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
deprecated_bytesize
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9672
Build 17242: Default Diff Build & Tests
Build 17241: arc lint + arc unit

Event Timeline

majcosta created this revision.Feb 29 2020, 17:58
Owners added a reviewer: Restricted Owners Package.Feb 29 2020, 17:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 29 2020, 17:58
teamcity added a comment.Feb 29 2020, 17:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 29 2020, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9667: Diff 16665.Feb 29 2020, 18:08
deadalnix requested changes to this revision.Feb 29 2020, 22:54
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/paymentserver.cpp
769 ↗(On Diff #16665)

This should be a size_t

This revision now requires changes to proceed.Feb 29 2020, 22:54
majcosta updated this revision to Diff 16671.Feb 29 2020, 23:58

changed to using Qt types to avoid implicit conversions

teamcity added a comment.Feb 29 2020, 23:59

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 1 2020, 00:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9672: Diff 16671.Mar 1 2020, 00:08
deadalnix accepted this revision.Mar 1 2020, 00:42
This revision is now accepted and ready to land.Mar 1 2020, 00:42
Closed by commit rABC40e56e8fcc93: Stop using the deprecated google::protobuf::MessageLite::ByteSize() (authored by majcosta). · Explain WhyMar 1 2020, 00:48
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC40e56e8fcc93: Stop using the deprecated google::protobuf::MessageLite::ByteSize().
majcosta mentioned this in D5392: revert to deprecated protobuf ByteSize() due to compatibility.Mar 1 2020, 15:48
majcosta mentioned this in rABCff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility.Mar 1 2020, 22:44
majcosta added a commit: rSTAGING40e56e8fcc93: Stop using the deprecated google::protobuf::MessageLite::ByteSize().Apr 7 2020, 23:10
majcosta mentioned this in rSTAGINGff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility.
Fabien added a reverting change: D6275: Fix deprecated ByteSize() for protobuf >= 3.1.May 28 2020, 10:04
Fabien added a reverting change: rABCeb87697b0e40: Fix deprecated ByteSize() for protobuf >= 3.1.May 28 2020, 14:45

Revision Contents
Changeset List

PathSize
src/
qt/
8 lines

Diff 16671

View Options

src/qt/paymentserver.cpp

Loading...