Page MenuHomePhabricator

Use cash magic by default when etablishing connection to new peers.

Authored by deadalnix on Sep 17 2017, 15:47.



Node still accept incomming connection from nodes that do not use the new cash magic. The deployed base of ABC and classic nodes taht do support the new cash magic is large enough.

Test Plan

Run a node using the new cash magic for a while. Assert it has peers that use the cash magic and others that do not using the getpeerinfo RPC.

Diff Detail

rABC Bitcoin ABC
Lint Not Applicable
Tests Not Applicable

Event Timeline

schancel added a subscriber: schancel.

Seems sane, but I'm still getting my sea legs. Someone else should review also.

3138 ↗(On Diff #1386)

This compares the message header from the new node to see if the new node has the same chainparams as the current node?

This revision is now accepted and ready to land.Sep 17 2017, 21:25
3138 ↗(On Diff #1386)

We want to use the Cash magic by default, but still accept connection from peer that still use the legacy magic. If the node is using the legacy magic, then we update the flag to reflect so.

This revision was automatically updated to reflect the committed changes.