Node still accept incomming connection from nodes that do not use the new cash magic. The deployed base of ABC and classic nodes taht do support the new cash magic is large enough.
Details
Details
- Reviewers
freetrader CCulianu dagurval schancel - Group Reviewers
Restricted Project - Commits
- rSTAGING61ac0e7c0d6f: Use cash magic by default when etablishing connection to new peers.
rABC61ac0e7c0d6f: Use cash magic by default when etablishing connection to new peers.
Run a node using the new cash magic for a while. Assert it has peers that use the cash magic and others that do not using the getpeerinfo RPC.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Seems sane, but I'm still getting my sea legs. Someone else should review also.
| src/net_processing.cpp | ||
|---|---|---|
| 3138 ↗ | (On Diff #1386) | This compares the message header from the new node to see if the new node has the same chainparams as the current node? |
| src/net_processing.cpp | ||
|---|---|---|
| 3138 ↗ | (On Diff #1386) | We want to use the Cash magic by default, but still accept connection from peer that still use the legacy magic. If the node is using the legacy magic, then we update the flag to reflect so. |