Page MenuHomePhabricator

Support cashaddr in Qt input validation
ClosedPublic

Authored by dagurval on Sep 21 2017, 23:34.

Details

Summary

This makes Qt address input fields accept cash addresses.

Test Plan

added unittest, manual test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
16-10-guivalidation
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1190
Build 1190: arc lint + arc unit

Event Timeline

dagurval retitled this revision from [cashaddr] Check for cashaddr in GUI validation to Support cashaddr in Qt input validation.Nov 16 2017, 12:21
dagurval edited the summary of this revision. (Show Details)

Currently requires full address, including prefix.

deadalnix requested changes to this revision.Nov 16 2017, 19:04
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/qt/guiutil.cpp
153 ↗(On Diff #1796)

GetConfig

This revision now requires changes to proceed.Nov 16 2017, 19:04
freetrader added a subscriber: freetrader.

LGTM, tested ok.

src/qt/bitcoinaddressvalidator.cpp
54

Surprised that linter did not introduce a newline before this one.

deadalnix added inline comments.
src/qt/bitcoinaddressvalidator.cpp
36

size_t

src/qt/guiutil.cpp
153

Considering the configs give access to the params, it's kind of weird that you need both in there.

This revision is now accepted and ready to land.Nov 29 2017, 21:03
This revision was automatically updated to reflect the committed changes.