Page MenuHomePhabricator

[debian release] Fetch signer string from GPG rather than requiring the user to enter a perfectly formatted one
ClosedPublic

Authored by jasonbcox on Tue, Mar 24, 00:12.

Details

Summary

This allows the releaser to type fewer characters with simpler formatting requirements.
See test plan for examples.

Test Plan
./debian-packages.sh --dry-run jason
./debian-packages.sh --dry-run jasonbcox
./debian-packages.sh --dry-run jasonbcox@bitcoinabc.org
./debian-packages.sh --dry-run 3BB16D0
./debian-packages.sh --dry-run 1  # fails due to too many matches
./debian-packages.sh --dry-run blah  # fails due to no matches

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Tue, Mar 24, 00:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 24, 00:12
Fabien requested changes to this revision.Tue, Mar 24, 09:24
Fabien added a subscriber: Fabien.

This does not guarantee that you will use the expected key. For example I have several keys with my name and various email addresses, and the script could randomly pick any of these.
The input should be unique. Another approach would be to filter using the keys.txt file from the repo.

This revision now requires changes to proceed.Tue, Mar 24, 09:24
jasonbcox updated this revision to Diff 17150.Tue, Mar 24, 16:19

Make the key fetching more robust against both too many and no matches

Fabien accepted this revision.Tue, Mar 24, 16:27
This revision is now accepted and ready to land.Tue, Mar 24, 16:27
jasonbcox edited the test plan for this revision. (Show Details)Tue, Mar 24, 16:51