[debian release] Fetch signer string from GPG rather than requiring the user to enter a perfectly formatted one
ClosedPublic
Actions

Authored by jasonbcox on Mar 24 2020, 00:12.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING0cf235df5a0f: [debian release] Fetch signer string from GPG rather than requiring the user to…
rABC0cf235df5a0f: [debian release] Fetch signer string from GPG rather than requiring the user to…

Summary

This allows the releaser to type fewer characters with simpler formatting requirements.
See test plan for examples.

Test Plan

./debian-packages.sh --dry-run jason
./debian-packages.sh --dry-run jasonbcox
./debian-packages.sh --dry-run jasonbcox@bitcoinabc.org
./debian-packages.sh --dry-run 3BB16D0
./debian-packages.sh --dry-run 1  # fails due to too many matches
./debian-packages.sh --dry-run blah  # fails due to no matches

Diff Detail

Repository

rABC Bitcoin ABC

Branch

get-signer-from-gpg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9946
Build 17746: Default Diff Build & Tests
Build 17745: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 24 2020, 00:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 24 2020, 00:12

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9946: Diff 17129.Mar 24 2020, 00:22

This does not guarantee that you will use the expected key. For example I have several keys with my name and various email addresses, and the script could randomly pick any of these.
The input should be unique. Another approach would be to filter using the keys.txt file from the repo.

This revision now requires changes to proceed.Mar 24 2020, 09:24

Make the key fetching more robust against both too many and no matches

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

Fabien accepted this revision.Mar 24 2020, 16:27

This revision is now accepted and ready to land.Mar 24 2020, 16:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9956: Diff 17150.Mar 24 2020, 16:31

jasonbcox edited the test plan for this revision. (Show Details)Mar 24 2020, 16:51

Closed by commit rABC0cf235df5a0f: [debian release] Fetch signer string from GPG rather than requiring the user to… (authored by jasonbcox). · Explain WhyMar 24 2020, 16:52

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC0cf235df5a0f: [debian release] Fetch signer string from GPG rather than requiring the user to….

jasonbcox added a commit: rSTAGING0cf235df5a0f: [debian release] Fetch signer string from GPG rather than requiring the user to….Apr 7 2020, 23:27