Include MacOS headers in global namespace
ClosedPublic
Actions

Authored by kyuupichan on Sep 25 2017, 08:10.

Details

Reviewers

deadalnix
dagurval

Group Reviewers

Restricted Project

Commits

rSTAGING0d6c1360cd6b: Include MacOS headers in global namespace
rABC0d6c1360cd6b: Include MacOS headers in global namespace

Summary

Unbreaks build on MacOSX

Test Plan

I confirm it now builds

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mac_build_fix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 887
Build 887: arc lint + arc unit

Event Timeline

kyuupichan created this revision.Sep 25 2017, 08:10

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptSep 25 2017, 08:10

dagurval accepted this revision.Sep 25 2017, 08:37

dagurval added a subscriber: dagurval.

dagurval added inline comments.

src/qt/guiutil.cpp
75	It's good enough to put that comment in the commit and not here IMO.

This revision is now accepted and ready to land.Sep 25 2017, 08:37

Closed by commit rABC0d6c1360cd6b: Include MacOS headers in global namespace (authored by kyuupichan, committed by kyuupichan). · Explain WhySep 25 2017, 12:56

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in D4482: qt: Add GUIUtil::bringToFront.Nov 20 2019, 09:38

Revision Contents
Changeset List

Path

Size

src/

qt/

guiutil.cpp

7 lines

Diff 1409

View Options

Include MacOS headers in global namespaceClosedPublicActions